Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(compiler): always use incremental program for compilerHost option #1535

Merged
merged 1 commit into from Apr 17, 2020
Merged

chore(compiler): always use incremental program for compilerHost option #1535

merged 1 commit into from Apr 17, 2020

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Apr 17, 2020

Summary

Since compilerHost option is still in experimental mode, I don't expect many users use it. Anyways, it is still a breaking change.

Test plan

Green CI

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N.A.

@ahnpnl ahnpnl requested a review from kulshekhar as a code owner April 17, 2020 07:16
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4429

  • 12 of 12 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 92.817%
Files with Coverage Reduction New Missed Lines %
src/compiler/program.ts 2 92.05%
Totals Coverage Status
Change from base Build 4427: -0.2%
Covered Lines: 1169
Relevant Lines: 1206
💛 - Coveralls

@ahnpnl ahnpnl merged commit a7250b6 into kulshekhar:master Apr 17, 2020
@ahnpnl ahnpnl deleted the drop-program branch April 17, 2020 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulshekhar kulshekhar kulshekhar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ahnpnl @coveralls @kulshekhar