Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(compiler): clean up codes and update docs for isolatedModules: false #1544

Closed
wants to merge 4 commits into from
Closed

chore(compiler): clean up codes and update docs for isolatedModules: false #1544

wants to merge 4 commits into from

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Apr 19, 2020

Summary

This PR updates:

Test plan

  • Green CI

Does this PR introduce a breaking change?

  • [] Yes
  • No

Other information

N.A

@ahnpnl ahnpnl requested a review from kulshekhar as a code owner April 19, 2020 19:43
@coveralls
Copy link

coveralls commented Apr 19, 2020

Pull Request Test Coverage Report for Build 4476

  • 15 of 15 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 92.962%

Totals Coverage Status
Change from base Build 4473: 0.1%
Covered Lines: 1098
Relevant Lines: 1133

馃挍 - Coveralls

@ahnpnl
Copy link
Collaborator Author

ahnpnl commented Apr 19, 2020

this branch is branched from the other PR so it contains the commit of the other PR. Please check the other PR first before checking this one.

@ahnpnl ahnpnl changed the title chore(compiler): improve performance when using isolatedModules: false chore(compiler): clean up codes and update docs for isolatedModules: false Apr 20, 2020
@ahnpnl ahnpnl closed this Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants