Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(devs-infra): minimum node version at 10.21.0 #1793

Merged
merged 2 commits into from Jul 12, 2020
Merged

chore(devs-infra): minimum node version at 10.21.0 #1793

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e19cbe
chore(devs-infra): minimum node version at 10.21.0
ahnpnl Jul 11, 2020
f8eab2e
Merge branch 'master' into ahnpnl-patch-1
ahnpnl Jul 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Expand Up @@ -130,6 +130,6 @@
]
},
"engines": {
"node": ">= 10"
"node": ">= 10.21.0"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a user has the engine-strict flag set to true, they won't be able to use ts-jest with node versions < 10.21.0, right?
Do we want that behavior?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change doesn't impact to end users unless we distribute ts-jest with engineStrict: true in our package.json. I've tested the scenario that end users set engineStrict: true but it doesn't prevent from installing ts-jest. Only when we explicitly set in our package.json, then end users won't be able to install.

So this change is safe, only for local ts-jest development.

}
}