Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(devs-infra): allow extending TsJestTransformer #2137

Merged
merged 2 commits into from Nov 17, 2020
Merged

build(devs-infra): allow extending TsJestTransformer #2137

merged 2 commits into from Nov 17, 2020

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Nov 16, 2020

Summary

Allow end users to extend TsJestTransformer with class inheritance. Partially revert #2122

Test plan

Green CI

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N.A.

@ahnpnl
build(devs-infra): allow extending TsJestTransformer
e0c7519 
Allow end users to extend `TsJestTransformer` with class inheritance
@coveralls
Copy link

coveralls commented Nov 16, 2020 •
edited

Pull Request Test Coverage Report for Build 368217244

  • 67 of 67 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.55%
Totals Coverage Status
Change from base Build 367640638: 0%
Covered Lines: 969
Relevant Lines: 999
💛 - Coveralls

@ahnpnl ahnpnl marked this pull request as ready for review November 16, 2020 08:56
@ahnpnl ahnpnl merged commit b686b22 into kulshekhar:master Nov 17, 2020
@ahnpnl ahnpnl deleted the allow-extend branch November 17, 2020 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulshekhar kulshekhar kulshekhar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ahnpnl @coveralls @kulshekhar