Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler): make sure language service use updated compiler options #2628

Merged
merged 1 commit into from May 26, 2021
Merged

fix(compiler): make sure language service use updated compiler options #2628

merged 1 commit into from May 26, 2021

Commits on May 26, 2021

  1. fix(compiler): make sure language service use updated compiler options 

    When a file initially exists in compiler file set when `TsCompiler` is created, later in `getCompiledOutput` the value of `compilerOptions` which makes `LanguageService` is not aware of because `_updateMemoryCache` checks and sees that the file is the same so `projectVersion` value is not increased which makes `LanguageService` uses the outdated `_compilerOptions`.

This commit adds a comparison via JSON stringify between `_compilerOptions` and `_initialCompilerOptions`. If there is a difference, increase `projectVersion` for `LanguageService`.
    @cexbrayat @ahnpnl
    cexbrayat authored and ahnpnl committed May 26, 2021
    Copy the full SHA
    bbffcfc View commit details
    Browse the repository at this point in the history