Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(devs-infra): release docs for v29.0.0 #3799

Merged
merged 1 commit into from Sep 9, 2022
Merged

docs(devs-infra): release docs for v29.0.0 #3799

merged 1 commit into from Sep 9, 2022

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Sep 9, 2022

No description provided.

@Smrtnyk
Copy link

Smrtnyk commented Sep 9, 2022

I bumped ts-jest to 29, and now my tests fail because describe, it is not recognized, and it asks me to install @types/jest.
If I downgrade it works again

@ahnpnl
Copy link
Collaborator Author

ahnpnl commented Sep 9, 2022

That is out of scope for ts-jest, those are Jest apis. We don’t do anything with typings.

@Smrtnyk
Copy link

Smrtnyk commented Sep 9, 2022

thats weird, because in another package I got jest 29 with swc and no issues with typings

@coveralls
Copy link

coveralls commented Sep 9, 2022

Pull Request Test Coverage Report for Build 3021650841

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 96.361%

Totals Coverage Status
Change from base Build 3020977864: 0.4%
Covered Lines: 4003
Relevant Lines: 4100

💛 - Coveralls

@ahnpnl
Copy link
Collaborator Author

ahnpnl commented Sep 9, 2022

Probably because of this clean up #3592 which now peer dep is @jest/types

Swc doesn’t perform type checking so you won’t see the issue

@Smrtnyk
Copy link

Smrtnyk commented Sep 9, 2022

Thats weird because I definitely have @types/jest installed, and even intellij IDE doesnt complain.
Will downgrade for now until I figure our what is the issue

@Smrtnyk
Copy link

Smrtnyk commented Sep 9, 2022

Ooh, I see, I need to also install @jest/types

@ahnpnl
Copy link
Collaborator Author

ahnpnl commented Sep 9, 2022

Jest team is moving slowly from @types/jest to @jest/types. ts-jest uses @jest/types for public typings but not about describe or it. Previously it worked before 28.0.4 because package manager would install @types/jest.

A bit update to documentation is needed.

@ahnpnl ahnpnl merged commit 99f87ff into kulshekhar:main Sep 9, 2022
@ahnpnl ahnpnl deleted the docs/v29.0.0-docs branch September 9, 2022 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants