Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes no JS compilation thru TS with allowJs #742

Merged
merged 3 commits into from Sep 20, 2018
Merged

Fixes no JS compilation thru TS with allowJs #742

merged 3 commits into from Sep 20, 2018

Conversation

huafu
Copy link
Collaborator

@huafu huafu commented Sep 20, 2018

this PR fixes #740

@huafu huafu added this to the v23.10.1 milestone Sep 20, 2018
@coveralls
Copy link

coveralls commented Sep 20, 2018 •
edited

Pull Request Test Coverage Report for Build 1872

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 90.771%
Totals Coverage Status
Change from base Build 1871: 0.01%
Covered Lines: 973
Relevant Lines: 1022
💛 - Coveralls

@huafu huafu merged commit ab94359 into kulshekhar:master Sep 20, 2018
@huafu huafu deleted the fix-740-no-js-compilation-with-allow-js branch September 20, 2018 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulshekhar kulshekhar kulshekhar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v23.10.1
Development

Successfully merging this pull request may close these issues.

Regression: no typescript transformation/compilation possible for JavaScript files any more
3 participants
@huafu @coveralls @kulshekhar