Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kubectl): support specifying profile name when installing control planes #10103

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

jijiechen
Copy link
Contributor

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues
    • N/A
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS
    • Confirmed
  • Tests (Unit test, E2E tests, manual test on universal and k8s)
    • Tested with unit tests and manual tests
    • Don't forget ci/ labels to run additional/fewer tests
      • Done
  • Do you need to update UPGRADE.md?
    • No
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label)
    • No

Two features are included:

  • Added the ability to specify a profile name that has been supported by a builtin values.{profile}.yaml.
  • Provided a production profile for Kuma so that:
    • resources claims are generally higher than the default demo proifle
    • make resource requests/limits to be identical so that pod will be guaranteed on clusters
    • autoscalling is open
    • pod disruption budgets are open

…lanes

Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>
Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>
@jijiechen jijiechen requested a review from a team as a code owner April 28, 2024 08:50
@jijiechen jijiechen requested review from michaelbeaumont, slonka and lobkovilya and removed request for a team April 28, 2024 08:50
…n they are not enabled

Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>
…epos to use

Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>
…rver

Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>
Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>
@jijiechen jijiechen marked this pull request as draft April 29, 2024 08:27
@lahabana
Copy link
Contributor

lahabana commented May 6, 2024

Do we need this in the end?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants