Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(MADR): policy on namespace #10148

Merged
merged 30 commits into from
May 23, 2024
Merged

docs(MADR): policy on namespace #10148

merged 30 commits into from
May 23, 2024

Conversation

lobkovilya
Copy link
Contributor

@lobkovilya lobkovilya commented Apr 30, 2024 •
edited

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues -- Fix MADR for applying new policies on different namespaces #7269
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

lobkovilya and others added 3 commits April 30, 2024 16:28
@lobkovilya
wip intro
37c805e 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@Automaat
feat(madr): add section
fb612a8 
Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>
@lobkovilya
cross-policy references
c182965 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya lobkovilya added the ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change) label Apr 30, 2024
@lobkovilya lobkovilya requested a review from a team as a code owner April 30, 2024 20:01
@lobkovilya lobkovilya requested review from jijiechen, jakubdyszkiewicz and lukidzi and removed request for a team April 30, 2024 20:01
@lobkovilya
remove repeating parts
915852e 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya
unnecessary word
d5f287d 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya
typos
4d2719b 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya lobkovilya mentioned this pull request May 6, 2024
Open
@lobkovilya lobkovilya changed the title docs(MADR): Policy On Namespace docs(MADR): policy on namespace May 6, 2024
@lobkovilya lobkovilya mentioned this pull request May 6, 2024
Open
lahabana
lahabana reviewed May 6, 2024
View reviewed changes
docs/madr/decisions/046-policy-on-namespace.md Outdated Show resolved Hide resolved
docs/madr/decisions/046-policy-on-namespace.md Outdated Show resolved Hide resolved
docs/madr/decisions/046-policy-on-namespace.md Outdated Show resolved Hide resolved
docs/madr/decisions/046-policy-on-namespace.md Outdated Show resolved Hide resolved
docs/madr/decisions/046-policy-on-namespace.md Outdated Show resolved Hide resolved
docs/madr/decisions/046-policy-on-namespace.md Outdated Show resolved Hide resolved
@lobkovilya lobkovilya mentioned this pull request May 6, 2024
Open
@lobkovilya @lahabana
Update docs/madr/decisions/046-policy-on-namespace.md
9c7c850 
Co-authored-by: Charly Molter <charly.molter@konghq.com>
Signed-off-by: Ilya Lobkov <lobkovilya@yandex.ru>
Automaat and others added 4 commits May 9, 2024 11:57
@Automaat
feat(madr): code review
36add6a 
Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>
@Automaat
feat(madr): code review
cf48276 
Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>
@lobkovilya
Merge branch 'master' into docs/madr-046
3036bf3
@lobkovilya
update MADR to reflect new behaviour
db02685 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya lobkovilya force-pushed the docs/madr-046 branch 2 times, most recently from 6b7bf7a to db02685 Compare May 15, 2024 08:13
lahabana
lahabana reviewed May 17, 2024
View reviewed changes
docs/madr/decisions/049-policy-on-namespace.md Outdated Show resolved Hide resolved
docs/madr/decisions/049-policy-on-namespace.md Outdated Show resolved Hide resolved
docs/madr/decisions/049-policy-on-namespace.md Outdated Show resolved Hide resolved
docs/madr/decisions/049-policy-on-namespace.md Outdated Show resolved Hide resolved
docs/madr/decisions/049-policy-on-namespace.md Outdated Show resolved Hide resolved
docs/madr/decisions/049-policy-on-namespace.md Outdated Show resolved Hide resolved
docs/madr/decisions/049-policy-on-namespace.md Outdated Show resolved Hide resolved
docs/madr/decisions/049-policy-on-namespace.md Outdated Show resolved Hide resolved
docs/madr/decisions/049-policy-on-namespace.md Outdated Show resolved Hide resolved
Automaat and others added 5 commits May 21, 2024 17:26
@Automaat
feat(madr): code review
c61ebf3 
Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>
@Automaat
feat(madr): code review
d5fe5dc 
Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>
@lobkovilya
producer/consumer udpate
83167d8 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya
mention RBAC in 'decision drivers'
82ad59c 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya
code review
55c7ef3 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya
minor adjustments
7c392e1 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya
Update docs/madr/decisions/049-policy-on-namespace.md
b911976 
Signed-off-by: Ilya Lobkov <lobkovilya@yandex.ru>
lahabana
lahabana reviewed May 23, 2024
View reviewed changes
docs/madr/decisions/049-policy-on-namespace.md Outdated Show resolved Hide resolved
docs/madr/decisions/049-policy-on-namespace.md Outdated Show resolved Hide resolved
docs/madr/decisions/049-policy-on-namespace.md Outdated Show resolved Hide resolved
docs/madr/decisions/049-policy-on-namespace.md Outdated Show resolved Hide resolved
docs/madr/decisions/049-policy-on-namespace.md Outdated Show resolved Hide resolved
docs/madr/decisions/049-policy-on-namespace.md Outdated Show resolved Hide resolved
docs/madr/decisions/049-policy-on-namespace.md Outdated Show resolved Hide resolved
docs/madr/decisions/049-policy-on-namespace.md Outdated Show resolved Hide resolved
docs/madr/decisions/049-policy-on-namespace.md Outdated Show resolved Hide resolved
lobkovilya and others added 7 commits May 23, 2024 10:41
@lobkovilya
review
05f57db 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya
Merge branch 'docs/madr-046' of https://github.com/kumahq/kuma into d…
aeba652 
…ocs/madr-046
@lobkovilya
review
8f90d57 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya @lahabana
Update docs/madr/decisions/049-policy-on-namespace.md
3c0a305 
Co-authored-by: Charly Molter <charly.molter@konghq.com>
Signed-off-by: Ilya Lobkov <lobkovilya@yandex.ru>
@lobkovilya
review
bb647aa 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya
Merge branch 'docs/madr-046' of https://github.com/kumahq/kuma into d…
26b5d80 
…ocs/madr-046
@lobkovilya
review
b6b619c 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@Automaat
feat(madr): code review
05bb792 
Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>
@lobkovilya
Merge branch 'master' into docs/madr-046
93a2ac7
@lobkovilya
adjust file number
910c793 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya lobkovilya merged commit 180976f into master May 23, 2024
11 checks passed
@lobkovilya lobkovilya deleted the docs/madr-046 branch May 23, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelbeaumont michaelbeaumont michaelbeaumont approved these changes

@Icarus9913 Icarus9913 Icarus9913 left review comments

@lahabana lahabana lahabana approved these changes

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

@Automaat Automaat Automaat approved these changes

@jijiechen jijiechen Awaiting requested review from jijiechen jijiechen is a code owner automatically assigned from kumahq/kuma-maintainers

@lukidzi lukidzi Awaiting requested review from lukidzi lukidzi is a code owner automatically assigned from kumahq/kuma-maintainers

Assignees
No one assigned
Labels
ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MADR for applying new policies on different namespaces
6 participants
@lobkovilya @lahabana @michaelbeaumont @jakubdyszkiewicz @Automaat @Icarus9913