feat(metrics): support OpenMetrics from applications #7125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…umahq#7092)" This reverts commit bba743f. Signed-off-by: AyushSenapati <a.p.senapati008@gmail.com>
AyushSenapati
requested review from
Automaat and
bartsmykla
and removed request for
a team
6 tasks
If mediatype is text/plain, return Prometheus text format without checking the version param. Signed-off-by: AyushSenapati <a.p.senapati008@gmail.com>
If application supports openmetrics format, attempt to make envoy stats compatible with openmetrics format Signed-off-by: AyushSenapati <a.p.senapati008@gmail.com>
Signed-off-by: AyushSenapati <a.p.senapati008@gmail.com>
Signed-off-by: AyushSenapati <a.p.senapati008@gmail.com>
michaelbeaumont
changed the title
Instead of converting bytes to string and use regex to dedup new line characters and trim spaces, do the processing on byte data. Signed-off-by: AyushSenapati <a.p.senapati008@gmail.com>
Signed-off-by: AyushSenapati <a.p.senapati008@gmail.com>
AyushSenapati
force-pushed
the
revert-honour-app-contenttype
branch
from
944e403
to
30726d0
Compare
In case of FmtUnknown, as we are using Negotiate instead of NegotiateWithOpenmetrics, change the expected content type to FmtText from FmtOpenMetrics Signed-off-by: AyushSenapati <a.p.senapati008@gmail.com>
Signed-off-by: AyushSenapati <a.p.senapati008@gmail.com>
Process Metrics already tests what processNewlineChars function tests. So remove the unit test for processNewlineChars function. Signed-off-by: AyushSenapati <a.p.senapati008@gmail.com>
bartsmykla
reviewed
Jul 13, 2023
- Use expfmt exposed consts instead of custom defined ones. - Do not handle err returned by buf.Write() as it is always nil. Signed-off-by: AyushSenapati <a.p.senapati008@gmail.com>
bartsmykla
reviewed
Jul 17, 2023
Signed-off-by: AyushSenapati <a.p.senapati008@gmail.com>
bartsmykla
approved these changes
Jul 17, 2023
|
@AyushSenapati I'm gonna test if everything works, and if @michaelbeaumont won't have anything against we could merge it |
|
Ok, tested with |
|
Once again @AyushSenapati thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit bba743f.
Checklist prior to review
syscall.Mkfifohave equivalent implementation on the other OS --UPGRADE.md? --> Changelog:entry here or add aci/label to run fewer/more tests?