-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 82 #111
Issue 82 #111
Conversation
Thank you, good findings 👍 |
Co-authored-by: Jukka Kurkela <jukka.kurkela@gmail.com>
Quality Gate passedIssues Measures |
Sorry, there was a small bug that I fixed because we were calling |
Merged! I'm not able to do a version bump for couple of days though. So if you're eager to get this released, a pr for version bumb would help 😉 |
Fix #81 and #82.
Currently, in the case of user-provided columns, the
maxX
value returned bycalculateX
can be computed incorrectly, because it always returns the finalx
value created in the while loop that processes each column. In the case of user-provided columns, the nodes already havex
values that may be higher than this value. Take for example the following data from #82:In this case, the highest value of
x
in the node collection will be 4, but because all 4 edges lead to a single node,calculateX
will return 1. This change fixes this issue by iterating over all nodes and taking the maximum value ofx
instead, so even in the case of user-provided columns the correct value formaxX
will be returned.This pull request also fixes a runtime error that can occur in the case that there is no node whose
x
value matches a given column.Thank you for your consideration.