Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type compatibility with Chart.js v3.5.0 #50

Merged
merged 1 commit into from Oct 28, 2021

Conversation

votdev
Copy link
Contributor

@votdev votdev commented Oct 27, 2021

Fixes: #49

Signed-off-by: Volker Theile votdev@gmx.de

Fixes: kurkle#49

Signed-off-by: Volker Theile <votdev@gmx.de>
@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kurkle kurkle merged commit 6010c35 into kurkle:next Oct 28, 2021
@kurkle
Copy link
Owner

kurkle commented Oct 28, 2021

Thanks @votdev

@kurkle kurkle added bug Something isn't working types labels Oct 28, 2021
@stockiNail
Copy link
Collaborator

Thanks a lot!

Nevertheless, FYI there is still a warning:

....\chartjs-chart-treemap\types\index.esm.d.ts
  97:23  warning  Don't use `{}` as a type. `{}` actually means "any non-nullish value".
- If you want a type meaning "any object", you probably want `Record<string, unknown>` instead.
- If you want a type meaning "any value", you probably want `unknown` instead.
- If you want a type meaning "empty object", you probably want `Record<string, never>` instead  @typescript-eslint/ban-types

✖ 1 problem (0 errors, 1 warning)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does not work with ChartJS >= 3.5
3 participants