-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(storage): add support for Elasticsearch 8 #2523
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: we might want to update the copyright dates in the source files (in a separate PR).
@@ -19,18 +22,54 @@ runs: | |||
shell: bash | |||
|
|||
- run: | | |||
export KUZZLE_IMAGE=${{ inputs.KUZZLE_IMAGE }} | |||
docker compose -f ./.ci/services.yml up -d | |||
export KUZZLE_IMAGE=${{ inputs.kuzzle-image }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Create a new script run-services.sh that allow us to remove this piece of code
docker-compose.yml
Outdated
@@ -66,7 +66,16 @@ services: | |||
retries: 30 | |||
|
|||
elasticsearch: | |||
image: kuzzleio/elasticsearch:7 | |||
image: elasticsearch:8.11.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep ES 7 as the default
Quality Gate passedIssues Measures |
|
||
:::info | ||
Kuzzle cannot connect to both Elasticsearch 7 and Elasticsearch 8 at the same time. | ||
::: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it's not ::: but ``` here on these 7 lines (info & warning)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is part of the kuzzle documentation paradigm :)
* Update your clients and integrations to the latest version that's compatible with Elasticsearch 8.x, if not done already. | ||
* Monitor your cluster using the Monitoring API or third-party monitoring services. | ||
1. Troubleshoot | ||
* If you encounter any issues during the migration process, take advantage of the Elasticsearch documentation, forums, and issue trackers for troubleshooting information and support. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Align bullet point with the others
* If you encounter any issues during the migration process, take advantage of the Elasticsearch documentation, forums, and issue trackers for troubleshooting information and support. | |
* If you encounter any issues during the migration process, take advantage of the Elasticsearch documentation, forums, and issue trackers for troubleshooting information and support. |
Quality Gate passedIssues Measures |
Elasticsearch-8 branch has been created, work will continue from there. Thanks everyone that has participated in this. |
What does this PR do ?
The choice made is to keep kuzzle compatible to avoid breaking changes around the support of ES8.
We wanted to allow the user to OPT-IN for the feature. By default the majorVersion support will be 7 until Kuzzle v3.
So now, and new key is available under
This key will load the wanted sdk version and will allow the user to use the new features of ES8.
[ ] - Documentation
[ ] - tests
How should this be manually tested?
Other changes