Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix express.js example #247

Merged
merged 2 commits into from
May 14, 2024
Merged

fix express.js example #247

merged 2 commits into from
May 14, 2024

Conversation

Livshitz
Copy link
Contributor

Should be using createServerAdapter adapter to convert to express-compatible handler. Based on this issue conversation: #246 (comment)

Description

v5 changes created regression in the way express handled router.handle. The right way is anyway to use createServerAdapter (from @whatwg-node/server) to make itty's router express-compatible.

Related Issue

Link to the related issue: #246 (comment)

Type of Change (select one and follow subtasks)

  • [] Documentation (README.md)
  • Maintenance or repo-level work (e.g. linting, build, tests, refactoring, etc.)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
    • I have included test coverage
  • Breaking change (fix or feature that would cause existing functionality/userland code to not work as expected)
    • Explain why a breaking change is necessary:
  • This change requires (or is) a documentation update
    • I have added necessary local documentation (if appropriate)
    • I have added necessary itty.dev documentation (if appropriate)

Should be using `createServerAdapter` adapter to convert to express-compatible handler.
Based on this issue conversation: kwhitley#246 (comment)
@kwhitley kwhitley merged commit f4d79f0 into kwhitley:v5.x May 14, 2024
3 checks passed
@kwhitley
Copy link
Owner

Thanks, Elya! <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants