Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make cached library a warning #20

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Make cached library a warning #20

wants to merge 3 commits into from
+39 −21

Conversation

CarterLi
Copy link
Contributor

@kwin
Copy link
Owner

kwin commented May 25, 2023

Thanks a lot for the PR. Looks good at first glance. Will check more thoroughly in the next days.

@CarterLi
Copy link
Contributor Author

@kwin Any chance to get this reviewed?

potterpg
potterpg reviewed Aug 3, 2023
View reviewed changes
MacDependency/MachOModel.mm
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like these changes, but prefer the systemPurpleColor colour as used by the original suggester for the warning colour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potterpg potterpg potterpg left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@CarterLi @kwin @potterpg