Add Hebrew #166
Add Hebrew #166
Conversation
| @@ -112,6 +112,7 @@ Note: The Currency Transformer within this library processes integers; ensure yo | |||
| | Ukrainian | ua | + | + | | |||
| | Uzbek | uz | + | + | | |||
| | Yoruba | yo | + | + | | |||
| | Hebrew | he | + | + | | |||
There was a problem hiding this comment.
Could you please order the list alphabetically?
| @@ -44,6 +44,7 @@ trait ManagesNumberTransformers | |||
| 'ua' => Transformer\UkrainianNumberTransformer::class, | |||
| 'uz' => Transformer\UzbekNumberTransformer::class, | |||
| 'yo' => Transformer\YorubaNumberTransformer::class, | |||
| 'he' => Transformer\HebrewNumberTransformer::class, | |||
There was a problem hiding this comment.
Could you please add he on the list in the alphabetical order?
| @@ -32,6 +32,7 @@ trait ManagesCurrencyTransformers | |||
| 'ua' => Transformer\UkrainianCurrencyTransformer::class, | |||
| 'uz' => Transformer\UzbekCurrencyTransformer::class, | |||
| 'yo' => Transformer\YorubaCurrencyTransformer::class, | |||
| 'he' => Transformer\HebrewCurrencyTransformer::class, | |||
There was a problem hiding this comment.
Could you please add he on the list in the alphabetical order?
| ]; | ||
|
|
||
| public static array $currencyNames = [ | ||
| 'ALL' => [['lek'], ['qindarka']], |
There was a problem hiding this comment.
Could you please translate other currencies using Hebrew alphabet?
|
|
||
| class HebrewNounGenderInflector | ||
| { | ||
| /** |
There was a problem hiding this comment.
Could you please use type hinting instead of docblocks? This library requires min PHP7
| } | ||
|
|
||
| /** | ||
| * @param int $number |
There was a problem hiding this comment.
Could you please replace docblocks with type hints?
| return implode(' ', $words); | ||
| } | ||
|
|
||
| /** |
| $tens = ((int) ($number / 10)) % 10; | ||
|
|
||
| if ($number > 1 && $number <= 10) { | ||
| if($number === 2) { |
There was a problem hiding this comment.
PSR12 error
| if($number === 2) { | |
| if ($number === 2) { |
|
@kwn : How I can contribute to finalize this PR ? I tried on #167 , because it is just some test cases to add. But :
So i'm wonder (as a github noob) how to help on PR suggested by others ... |
No description provided.