This repository has been archived by the owner on Feb 27, 2020. It is now read-only.
feat(spellcheckerprovider): async spellchecker support #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: loadDictionary does not read physical file from path anymore
Codecov Report
@@ Coverage Diff @@
## master #389 +/- ##
======================================
Coverage 99.3% 99.3%
======================================
Files 3 3
Lines 143 143
Branches 25 25
======================================
Hits 142 142
Partials 1 1 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #389 +/- ##
========================================
- Coverage 99.3% 92.1% -7.2%
========================================
Files 3 4 +1
Lines 143 114 -29
Branches 25 17 -8
========================================
- Hits 142 105 -37
- Misses 0 6 +6
- Partials 1 3 +2
Continue to review full report at Codecov.
|
refactor(loaddictionary): only accept arraybuffer
BREAKING CHANGES: unloadDictionary does not reset webframe spellchecker
BREAKING CHANGE: spellchecker provider do not attach to webframe.setSpellcheckProvider
BREAKING CHANGE: switchDictionary deprecated
BREAKING CHANGE: provider interface is now async
feat(attachspellcheckerprovider): implement attach spellchecker provider
docs(example): update example code, remove separate pkg
docs(example): add example for worker
fix(provider): allow tree shake
test(provider): update test cases
docs(readme): update documentation
build(release): release 1.0.0-beta.7
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #218
This PR implements feature to support async spellchecker interface from electron@5.
PR doesn't include any backward interface compatibility, makes only supports electron@5 and above.
Notable breaking changes are
api surface has bit expanded by separating provider to attach into webframe. But this allows to instantiate provider in other thread / process, achieves true async spellchecker without blocking main thread. For simplicity, attachProvider accepts provider as-is if it's to be used in main thread.