Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add documentation #39

Merged
merged 3 commits into from
May 28, 2024
Merged

add documentation #39

merged 3 commits into from
May 28, 2024

Conversation

anoipm
Copy link
Contributor

@anoipm anoipm commented May 16, 2024

Description

Add documentation.

Related issue(s)
See also #11

@kyma-bot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@anoipm anoipm added area/docker-registry Issues related with the docker-registry module documentation Improvements or additions to documentation labels May 17, 2024
docs/user/README.md Outdated Show resolved Hide resolved
docs/user/README.md Outdated Show resolved Hide resolved
docs/user/README.md Outdated Show resolved Hide resolved

Still, it is very convenient for development and getting first-time experience with the Kyma Docker Registry.

1. Push Function image to the Docker Registry using the in-cluster URL.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are these steps? Is it something a user must do? For what purpose?
If it's only a list of the Docker Registry features, please use unordered list.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed these steps because it describes process from Serverless

@anoipm anoipm marked this pull request as ready for review May 27, 2024 10:31
@anoipm anoipm requested a review from a team as a code owner May 27, 2024 10:31
docs/user/00-20-configure-docker-registry.md Outdated Show resolved Hide resolved
docs/user/resources/06-20-docker-registry-cr.md Outdated Show resolved Hide resolved

4. Import the image to Docker Registry:

<!-- TODO: presiquites: kyma cli (new version) -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this comment is no longer needed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

docs/user/tutorials/01-10-simple-usage.md Outdated Show resolved Hide resolved
anoipm and others added 2 commits May 28, 2024 08:56
Co-authored-by: Grzegorz Karaluch <grzegorz.karaluch@sap.com>
@kyma-bot kyma-bot added the lgtm label May 28, 2024
@kyma-bot kyma-bot merged commit d24c801 into kyma-project:main May 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docker-registry Issues related with the docker-registry module cla: yes documentation Improvements or additions to documentation lgtm size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants