Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Archiver scenario and SQL scripts #739

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Archiver scenario and SQL scripts #739

wants to merge 8 commits into from

Conversation

piotrmiskiewicz
Copy link
Member

Description

Changes proposed in this pull request:

  • executing archiver scenario

Related issue(s)

@piotrmiskiewicz piotrmiskiewicz requested review from a team as code owners May 8, 2024 08:03
@kyma-bot kyma-bot added area/documentation Issues or PRs related to documentation cla: yes Indicates the PR's author has signed the CLA. labels May 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 8, 2024
IwonaLanger
IwonaLanger reviewed May 8, 2024
View reviewed changes
utils/archiver/db_scripts.md Outdated Show resolved Hide resolved
utils/archiver/db_scripts.md Outdated Show resolved Hide resolved
utils/archiver/db_scripts.md Outdated Show resolved Hide resolved
utils/archiver/db_scripts.md Outdated Show resolved Hide resolved
utils/archiver/db_scripts.md Outdated Show resolved Hide resolved
utils/archiver/scenario.md Outdated
Comment on lines 28 to 38
Set the following configurations for KEB:
```
archiving:
enabled: true
dryRun: false
cleaning:
enabled: true
dryRun: false
```

and wait for KEB restart with new configuration.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend numbering these two steps (lines 28 and 38).

utils/archiver/scenario.md Outdated Show resolved Hide resolved
utils/archiver/scenario.md Outdated Show resolved Hide resolved
utils/archiver/scenario.md Outdated Show resolved Hide resolved
utils/archiver/scenario.md Outdated Show resolved Hide resolved
IwonaLanger
IwonaLanger previously approved these changes May 8, 2024
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label May 8, 2024
@piotrmiskiewicz piotrmiskiewicz added the kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature label May 8, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label May 8, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label May 8, 2024
piotrmiskiewicz and others added 8 commits May 8, 2024 14:19
@piotrmiskiewicz
Archiver scenario and SQL scripts
d2787ea
@piotrmiskiewicz
wip
5aa9cb4
@piotrmiskiewicz
wip
5007762
@piotrmiskiewicz @jaroslaw-pieszka
Update utils/archiver/db_scripts.md
b6519d0 
Co-authored-by: Jarosław Pieszka <jaroslaw.pieszka@sap.com>
@piotrmiskiewicz @IwonaLanger
Apply suggestions from code review
5df3531 
Co-authored-by: Iwona Langer <iwona.langer@sap.com>
@piotrmiskiewicz @IwonaLanger
Update utils/archiver/scenario.md
c205fed 
Co-authored-by: Iwona Langer <iwona.langer@sap.com>
@piotrmiskiewicz
wip
6087445
@piotrmiskiewicz
wip (after review)
360612c
@kyma-bot kyma-bot removed the lgtm Looks good to me! label May 8, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IwonaLanger IwonaLanger IwonaLanger approved these changes

@jaroslaw-pieszka jaroslaw-pieszka jaroslaw-pieszka left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@jaroslaw-pieszka jaroslaw-pieszka

@IwonaLanger IwonaLanger

Labels
area/documentation Issues or PRs related to documentation cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@piotrmiskiewicz @jaroslaw-pieszka @IwonaLanger @kyma-bot