-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing Eval State Only if Changed in AVS #769
Merged
kyma-bot
merged 6 commits into
kyma-project:main
from
ralikio:bugfixes/conditional-avs-check
May 22, 2024
Merged
Changing Eval State Only if Changed in AVS #769
kyma-bot
merged 6 commits into
kyma-project:main
from
ralikio:bugfixes/conditional-avs-check
May 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add one of following labels |
kyma-bot
added
the
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
label
May 16, 2024
ralikio
added
the
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
label
May 16, 2024
ebensom
approved these changes
May 16, 2024
kyma-bot
added
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
and removed
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
labels
May 16, 2024
ebensom
approved these changes
May 16, 2024
ralikio
removed
the
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
label
May 20, 2024
New changes are detected. LGTM label has been removed. |
szwedm
approved these changes
May 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Orchestration logic in KEB keeps AVS maintenance mode in operation's Instance Details in operation.Avs.AvsInternalEvaluationStatus in its Original and Current fields.
Current behaviour is as follows:
The following fix corrects this behaviour by invoking
evalAssistant.SetEvalStatus(lifecycleData, status)
only if current KEB state is different then AVS state.Related issue(s)