Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Github action for the common logging library #18587

Closed
wants to merge 7 commits into from
Closed

Add Github action for the common logging library #18587

wants to merge 7 commits into from

Conversation

akgalwas
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Github Action that run tests for common logging library
  • Cleanup in the common lib:
    • removed the before-commit.sh script
    • removed resilient http client as it is not used in any projects

@akgalwas akgalwas requested review from a team as code owners February 21, 2024 14:45
@netlify Netlify
Copy link

netlify bot commented Feb 21, 2024 •
edited

👷 Deploy request for kyma-project pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit a7f5251

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 21, 2024
@netlify Netlify
Copy link

netlify bot commented Feb 21, 2024 •
edited

✅ Deploy Preview for kyma-project-docs-preview ready!

Name Link
🔨 Latest commit a7f5251
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/65d703ed26bbc50008f21b74
😎 Deploy Preview https://deploy-preview-18587--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@akgalwas akgalwas marked this pull request as draft February 21, 2024 15:26
@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 21, 2024
@m00g3n m00g3n self-assigned this Mar 11, 2024
@akgalwas akgalwas marked this pull request as ready for review March 11, 2024 10:22
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 11, 2024
m00g3n
m00g3n approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@m00g3n m00g3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyma-bot kyma-bot added the lgtm Looks good to me! label Mar 11, 2024
m00g3n
m00g3n approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@m00g3n m00g3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link

This pull request has been automatically marked as stale due to the lack of recent activity. It will soon be closed if no further activity occurs.
Thank you for your contributions.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 11, 2024
@github-actions GitHub Actions
Copy link

This pull request has been automatically closed due to the lack of recent activity.
/lifecycle rotten

@github-actions github-actions bot closed this May 19, 2024
@kyma-bot kyma-bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dekiel dekiel dekiel approved these changes

@m00g3n m00g3n m00g3n approved these changes

@mm-mariani mm-mariani Awaiting requested review from mm-mariani mm-mariani was automatically assigned from kyma-project/prow

Assignees

@dekiel dekiel

@m00g3n m00g3n

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@akgalwas @dekiel @m00g3n @kyma-bot