Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge env and e2e tests #1020

Closed
a-thaler opened this issue Apr 29, 2024 · 1 comment
Closed

Merge env and e2e tests #1020

a-thaler opened this issue Apr 29, 2024 · 1 comment
Assignees
Labels
area/tests Writing/adding/Refactoring tests or checks kind/chore Categorizes issue or PR as related to a chore.

Comments

@a-thaler
Copy link
Collaborator

a-thaler commented Apr 29, 2024

Description
For the telemetry-manager there are 3 different kind of test realized: unit test, env test, e2e test
It is hard to grasp when to write an env test and when to write an e2e test. ALso the used technology is different (one is a full integration test while the other mocks an apiserver)
To keep it simple, the team decided to remove the middle test layer.

Criterias

@shorim
Copy link
Contributor

shorim commented May 13, 2024

TODO list:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tests Writing/adding/Refactoring tests or checks kind/chore Categorizes issue or PR as related to a chore.
Projects
None yet
Development

No branches or pull requests

2 participants