Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Migrate logs env tests to e2e tests #1076

Merged
merged 32 commits into from
May 17, 2024

Conversation

shorim
Copy link
Contributor

@shorim shorim commented May 15, 2024

Description

Changes proposed in this pull request (what was done and why):

  • Migrating LogPipeline env tests:

    • Migrated unsupported Loki output test to an e2e test
    • Migrated secret rotation test to an e2e test
    • Migrated resources test (existence of expected resources and OwnerReferece is set correctly) to an e2e test. I added checks for more resources than the existing ones in the env test.
    • The remaining env tests were simply removed, as they were either checking for static values that are already tested using unit tests or they are implicitly tested in other e2e tests
  • Metrics and traces e2e resources tests:

    • Also removed the tests here which were checking for static values that are already tested using unit tests
    • Added further tests to check the existence of metrics service and network policy and that the OwnerReference value is set as expected
  • Metrics and traces e2e secret rotation tests:

    • These tests were using a secret with the same name (missing) and in the same namespace (default). This might have caused flakiness of the tests. This is fixed in this PR.
  • Telemetry e2e test:

    • Removed the test for unsupported Loki output, as the Telemetry conditions for this case is now checked in the logs unsupported Loki output e2e test.

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • New features have a milestone set.
  • New features have defined acceptance criteria in a corresponding GitHub Issue, and all criteria are satisfied with this PR.
  • The corresponding GitHub issue has a respective area and kind label.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • Adjusted the documentation if the change is user-facing.
  • The feature is unit-tested
  • The feature is e2e-tested

@shorim shorim added area/tests Writing/adding/Refactoring tests or checks do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/chore Categorizes issue or PR as related to a chore. labels May 15, 2024
@shorim shorim added this to the 1.16.0 milestone May 15, 2024
@shorim shorim requested a review from a team as a code owner May 15, 2024 11:03
@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 15, 2024
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label May 15, 2024
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 16, 2024
@kyma-bot kyma-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 16, 2024
@shorim shorim mentioned this pull request May 16, 2024
@skhalash skhalash self-assigned this May 17, 2024
test/testkit/kyma/common_names.go Outdated Show resolved Hide resolved
@kyma-bot kyma-bot added the lgtm Looks good to me! label May 17, 2024
@shorim shorim removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 17, 2024
@kyma-bot kyma-bot merged commit a54ee06 into kyma-project:main May 17, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tests Writing/adding/Refactoring tests or checks cla: yes Indicates the PR's author has signed the CLA. kind/chore Categorizes issue or PR as related to a chore. lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants