Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Introduce crd categories #1009

Merged
merged 7 commits into from
May 21, 2024
Merged

feat: Introduce crd categories #1009

merged 7 commits into from
May 21, 2024

Conversation

k15r
Copy link
Contributor

@k15r k15r commented Apr 23, 2024 •
edited by skhalash

Description

Changes proposed in this pull request (what was done and why):

  • group Pipelines into their own category "telemetry"

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • New features have a milestone set.
  • New features have defined acceptance criteria in a corresponding GitHub Issue, and all criteria are satisfied with this PR.
  • The corresponding GitHub issue has a respective area and kind label.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • Adjusted the documentation if the change is user-facing.
  • The feature is unit-tested
  • The feature is e2e-tested

@k15r k15r requested a review from a team as a code owner April 23, 2024 08:42
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 23, 2024
@k15r k15r changed the title feature: Introduce crd categories feat: Introduce crd categories Apr 23, 2024
skhalash
skhalash previously approved these changes Apr 26, 2024
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Apr 26, 2024
@skhalash
Copy link
Collaborator

Looks good! Do we have an agreement with other teams to use the kyma-modules category for module CRs?

@k15r
Copy link
Contributor Author

k15r commented May 3, 2024

Looks good! Do we have an agreement with other teams to use the kyma-modules category for module CRs?

nope, not yet. I assume the correct way to introduce it would be a proposal.

@skhalash skhalash added this to the 1.16.0 milestone May 16, 2024
@a-thaler a-thaler added kind/feature Categorizes issue or PR as related to a new feature. area/manager Manager or module changes labels May 17, 2024
@a-thaler a-thaler removed this from the 1.16.0 milestone May 17, 2024
@a-thaler a-thaler added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 17, 2024
@skhalash skhalash self-requested a review May 17, 2024 11:54
@a-thaler
Copy link
Collaborator

Let's wait for the next release (tuesday) till we merge it

@kyma-bot kyma-bot removed the lgtm Looks good to me! label May 21, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label May 21, 2024
@skhalash skhalash added this to the 1.17.0 milestone May 21, 2024
@skhalash
Copy link
Collaborator

/unhold

@kyma-bot kyma-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 21, 2024
@kyma-bot kyma-bot merged commit e8de168 into kyma-project:main May 21, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skhalash skhalash skhalash approved these changes

Assignees

@skhalash skhalash

Labels
area/manager Manager or module changes cla: yes Indicates the PR's author has signed the CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@k15r @skhalash @a-thaler @kyma-bot