Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Synchronize CRs Reasons #1038

Merged
merged 19 commits into from
May 17, 2024
Merged

feat: Synchronize CRs Reasons #1038

merged 19 commits into from
May 17, 2024

Conversation

TeodorSAP
Copy link
Member

@TeodorSAP TeodorSAP commented May 6, 2024 •
edited

Description

Changes proposed in this pull request (what was done and why):

  • New names and structure for the reasons used
    • Rename Deployment to Gateway
    • Rename Daemon to Agent
    • Delete CR prefixes (e.g. Log, Metric, Trace, Pipeline, etc.) and prefixing logic
    • Merge TLSCertificateInvalid reasons
  • Un-hardcode LogComponentsHealthy, TraceComponentsHealthy, and MetricComponentsHealthy condition types
  • Adapt documentation according to changes, and add missing reasons

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • New features have a milestone set.
  • New features have defined acceptance criteria in a corresponding GitHub Issue, and all criteria are satisfied with this PR.
  • The corresponding GitHub issue has a respective area and kind label.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • Adjusted the documentation if the change is user-facing.
  • The feature is unit-tested
  • The feature is e2e-tested

@TeodorSAP TeodorSAP requested review from a team as code owners May 6, 2024 11:14
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 6, 2024
@TeodorSAP TeodorSAP added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 6, 2024
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 6, 2024
@TeodorSAP TeodorSAP added this to the 1.16.0 milestone May 6, 2024
@TeodorSAP TeodorSAP added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 6, 2024
@NHingerl
Copy link
Contributor

NHingerl commented May 6, 2024

Should this be on the Huskies board?

@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 8, 2024
NHingerl
NHingerl previously approved these changes May 13, 2024
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label May 13, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label May 14, 2024
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 14, 2024
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 15, 2024
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 15, 2024
skhalash
skhalash previously requested changes May 16, 2024
View reviewed changes
internal/conditions/conditions.go Outdated Show resolved Hide resolved
docs/user/resources/02-logpipeline.md Outdated Show resolved Hide resolved
@TeodorSAP TeodorSAP requested a review from skhalash May 16, 2024 12:14
@TeodorSAP TeodorSAP dismissed skhalash’s stale review May 16, 2024 12:15

Changes implemented

@TeodorSAP TeodorSAP requested a review from NHingerl May 16, 2024 12:46
@skhalash skhalash changed the title chore: Synchronize CRs Reasons feat: Synchronize CRs Reasons May 16, 2024
@skhalash skhalash added area/logs LogPipeline area/metrics MetricPipeline area/tests Writing/adding/Refactoring tests or checks kind/feature Categorizes issue or PR as related to a new feature. labels May 16, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label May 16, 2024
@skhalash skhalash added area/traces TracePipeline area/manager Manager or module changes and removed area/tests Writing/adding/Refactoring tests or checks labels May 16, 2024
@kyma-bot kyma-bot merged commit c10378e into kyma-project:main May 17, 2024
31 checks passed
@TeodorSAP TeodorSAP linked an issue May 21, 2024 that may be closed by this pull request
Synchronize the reasons in CRs status messages for different signals #1023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-thaler a-thaler a-thaler left review comments

@skhalash skhalash skhalash approved these changes

@mmitoraj mmitoraj mmitoraj approved these changes

@NHingerl NHingerl Awaiting requested review from NHingerl

Assignees

@skhalash skhalash

@mmitoraj mmitoraj

Labels
area/logs LogPipeline area/manager Manager or module changes area/metrics MetricPipeline area/traces TracePipeline cla: yes Indicates the PR's author has signed the CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.

Synchronize the reasons in CRs status messages for different signals
6 participants
@TeodorSAP @NHingerl @skhalash @a-thaler @mmitoraj @kyma-bot