Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Enhance Dynatrace guide for metric scenario #1087

Merged
merged 3 commits into from
May 23, 2024

Conversation

a-thaler
Copy link
Collaborator

Description

Changes proposed in this pull request (what was done and why):

  • Restructered the metric section by outlining 3 different options
  • Provided more detailed instructions for all 3 options

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • New features have a milestone set.
  • New features have defined acceptance criteria in a corresponding GitHub Issue, and all criteria are satisfied with this PR.
  • The corresponding GitHub issue has a respective area and kind label.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • Adjusted the documentation if the change is user-facing.
  • The feature is unit-tested
  • The feature is e2e-tested

@a-thaler a-thaler requested a review from a team as a code owner May 16, 2024 16:13
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label May 16, 2024
@a-thaler a-thaler changed the title feat: Enhance Dynatrace guide for metric scenario docs: Enhance Dynatrace guide for metric scenario May 16, 2024
@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 16, 2024
@a-thaler a-thaler added kind/feature Categorizes issue or PR as related to a new feature. area/documentation Documentation changes labels May 16, 2024
Copy link
Contributor

@NHingerl NHingerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to look at it again when the current suggestions are resolved.
I'm not a big fan of the stacked lists but I doubt our style guide allows h4 headlines.
Overall, this document is getting pretty complicated :D

docs/user/integration/dynatrace/README.md Outdated Show resolved Hide resolved
docs/user/integration/dynatrace/README.md Outdated Show resolved Hide resolved
docs/user/integration/dynatrace/README.md Outdated Show resolved Hide resolved
docs/user/integration/dynatrace/README.md Outdated Show resolved Hide resolved
docs/user/integration/dynatrace/README.md Outdated Show resolved Hide resolved
docs/user/integration/dynatrace/README.md Outdated Show resolved Hide resolved
docs/user/integration/dynatrace/README.md Outdated Show resolved Hide resolved
docs/user/integration/dynatrace/README.md Outdated Show resolved Hide resolved
docs/user/integration/dynatrace/README.md Outdated Show resolved Hide resolved
Co-authored-by: Nina Hingerl <76950046+NHingerl@users.noreply.github.com>
@kyma-bot kyma-bot added the lgtm Looks good to me! label May 23, 2024
@kyma-bot kyma-bot merged commit e5de3ad into kyma-project:main May 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Documentation changes cla: yes Indicates the PR's author has signed the CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants