Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build in ADO by default. #10000

Closed
wants to merge 3 commits into from
Closed

Build in ADO by default. #10000

wants to merge 3 commits into from
+6 −2

Conversation

dekiel
Copy link
Contributor

@dekiel dekiel commented Mar 1, 2024 •
edited

Description

Changes proposed in this pull request:

  • Set true as default value for build-in-ado flag.

Resolve #9831

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 1, 2024
@kyma-bot
Copy link
Contributor

kyma-bot commented Mar 1, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 1, 2024
@dekiel dekiel added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Mar 1, 2024
@dekiel dekiel marked this pull request as ready for review March 1, 2024 21:28
@dekiel dekiel requested review from neighbors-dev-bot and a team as code owners March 1, 2024 21:28
@dekiel dekiel requested review from akiioto and Sawthis March 1, 2024 21:28
@kyma-bot kyma-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the CLA. labels Mar 1, 2024
akiioto
akiioto previously approved these changes Mar 25, 2024
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Mar 25, 2024
@kyma-bot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@kyma-bot kyma-bot removed the lgtm Looks good to me! label Apr 10, 2024
@dekiel dekiel requested a review from akiioto April 10, 2024 13:26
@dekiel
Copy link
Contributor Author

dekiel commented Jun 5, 2024

The integration with GitHub actions is ready. Integration force use ADO backend and user is not able to override this. All teams are suppose to migrate to use GitHub actions or switch to use Hyperspace solution directly. There is no need to enforce ADO backend in other use cases. After migration of all teams ADO backend will be the only one supported by image-builder.

@dekiel dekiel closed this Jun 5, 2024
@dekiel dekiel mentioned this pull request Jun 5, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neighbors-dev-bot neighbors-dev-bot Awaiting requested review from neighbors-dev-bot neighbors-dev-bot is a code owner

@Sawthis Sawthis Awaiting requested review from Sawthis Sawthis is a code owner automatically assigned from kyma-project/prow

@akiioto akiioto Awaiting requested review from akiioto

Assignees

@akiioto akiioto

Labels
cla: yes Indicates the PR's author has signed the CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set image-builder ADO backend as default
3 participants
@dekiel @kyma-bot @akiioto