Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WiP] excludes application-connector-manager from tide #10387

Open
wants to merge 1 commit into
base: acm-tide-exclude
Choose a base branch
from
Open

[WiP] excludes application-connector-manager from tide #10387

wants to merge 1 commit into from

Conversation

Disper
Copy link
Member

@Disper Disper commented Apr 11, 2024

Description

Changes proposed in this pull request:

  • excludes ACM from tide
  • ...
  • ...

Related issue(s)

@Disper Disper requested review from neighbors-dev-bot and a team as code owners April 11, 2024 10:22
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 11, 2024
@Disper Disper changed the title acm-exclude-tide excludes application-connector-manager from tide Apr 11, 2024
@Disper Disper changed the title excludes application-connector-manager from tide [WiP] excludes application-connector-manager from tide Apr 11, 2024
@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 11, 2024
@Disper
Copy link
Member Author

Disper commented Apr 11, 2024

/hold
we will try to use whitelisting to tide instead

@kyma-bot kyma-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 11, 2024
@Disper Disper mentioned this pull request Apr 11, 2024
Merged
@dekiel
Copy link
Contributor

dekiel commented Jun 3, 2024

@Disper is this PR still needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neighbors-dev-bot neighbors-dev-bot Awaiting requested review from neighbors-dev-bot neighbors-dev-bot is a code owner

@KacperMalachowski KacperMalachowski Awaiting requested review from KacperMalachowski KacperMalachowski is a code owner automatically assigned from kyma-project/prow

@TorstenD-SAP TorstenD-SAP Awaiting requested review from TorstenD-SAP TorstenD-SAP is a code owner automatically assigned from kyma-project/prow

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
cla: yes Indicates the PR's author has signed the CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Disper @dekiel @kyma-bot