Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling prow job pull requests in post submit jobs #10684

Merged
merged 4 commits into from
May 16, 2024

Conversation

KacperMalachowski
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Fix error, when pull request number was expected even during postsubmit job

Related issue(s)

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 16, 2024
@KacperMalachowski
Copy link
Contributor Author

/hold

@kyma-bot kyma-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 16, 2024
@KacperMalachowski
Copy link
Contributor Author

/unhold

@kyma-bot kyma-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 16, 2024
Sawthis
Sawthis previously approved these changes May 16, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label May 16, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label May 16, 2024
@kyma-bot kyma-bot merged commit e38815a into kyma-project:main May 16, 2024
9 checks passed
@KacperMalachowski KacperMalachowski deleted the fix-builder branch May 16, 2024 10:20
dekiel pushed a commit to dekiel/test-infra that referenced this pull request May 27, 2024
…#10684)

* Fix

* Fix handling postsubmits

* Fix test

* Add comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants