Update isPlainObject to exclude objects with constructors #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I don't think this works in every case. You need to at least add a test that checks all the old cases we were detecting specifically. And how about cases where there's no constructor? Like |
If you are using a custom type parser (via `pg.types.setTypeParser`) that returns a custom class, the camel case plugin will incorrectly serialize that value to a literal object, stripping it of its prototype. This is problematic if you rely on the ability to call certain methods specified by the custom class' prototype.
sds
force-pushed
the
sds/improve-plain-object-detection
branch
from
0e1eac8
to
abf0edb
Compare
|
Thanks for the feedback! Would you want a separate test file for In the meantime, I pushed an updated implementation that handles the |
|
@sds let's add a separate test file, and verify there is no regression. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey all, I'm not sure if this is the right solution to the issue we're observing, so would welcome feedback on a better way to solve.
If you are using a custom type parser (e.g. via
pg.types.setTypeParser) that returns a custom class, the camel case plugin will incorrectly serialize that value to a literal object, stripping it of its prototype.This is problematic if you rely on the ability to call certain methods specified by the custom class' prototype.
To date,
isPlainObjectis used only in the camel case and JSON parsing plugins. I'm not sure what the original intent of theisPlainObjectimplementation was, so let me know if we think this fix belongs in the camel case plugin.