Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DefaultHTTPErrorHandler: return error if marshalling JSON fails #2022

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

DefaultHTTPErrorHandler: return error if marshalling JSON fails #2022

wants to merge 2 commits into from

Commits on Nov 5, 2021

  1. add testcase with bad json content in NewHttpError 

    The /bad-json-err testcase fails with current code, it returns 200 Ok instead.
    @georgmu
    georgmu committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    a886a67 View commit details
    Browse the repository at this point in the history

  2. return InternalServerError in DefaultHTTPErrorHandler if c.JSON() fails 

    This returns the same response as when calling c.JSON() directly
    @georgmu
    georgmu committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    3b4096e View commit details
    Browse the repository at this point in the history