fix: empty project_id to google_project data source #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afiune
force-pushed
the
afiune/RAIN-37109/RAIN-39458/fix-empty-google-project-data-source
branch
from
2ffbe44
to
af4e0ff
Compare
A validation change hashicorp/terraform-provider-google#12846 was introduced in version `4.42.0` of the google provider. This validation makes all our GCP modules to fail with: ``` │ Error: "" project_id must be 6 to 30 with lowercase letters, digits, hyphens and start with a letter. Trailing hyphens are prohibited. │ │ with module.gcp_project_config.data.google_project.selected, │ on .terraform/modules/gcp_project_config/main.tf line 96, in data "google_project" "selected": │ 96: project_id = var.project_id ``` To solve this issue we are avoiding using the `google_project` data source when we know the `project_id` that was provided by the user. If the user does not provide a `project_id`, then we use the data source to discover the project from the google provider. Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
afiune
force-pushed
the
afiune/RAIN-37109/RAIN-39458/fix-empty-google-project-data-source
branch
from
af4e0ff
to
f1a584d
Compare
dmurray-lacework
approved these changes
Nov 15, 2022
afiune
deleted the
afiune/RAIN-37109/RAIN-39458/fix-empty-google-project-data-source
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A validation change hashicorp/terraform-provider-google#12846
was introduced in version
4.42.0of the google provider. Thisvalidation makes all our GCP modules to fail with:
To solve this issue we are avoiding using the
google_projectdatasource when we know the
project_idthat was provided by the user.If the user does not provide a
project_id, then we use the datasource to discover the project from the google provider.
How did you test this change?
Test should pass, plus we will test this in our private Terraform project https://github.com/lacework/terraform-customerdemo
Issue