Updates node-form-data dependency, 0.1.3->0.2.0, to fix webpack issue. #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs to depend on an exact version down to the patch level. What effect does this have on the bundle size? |
SuperAgent depends on node-form-data@0.1.3, which uses node-mime@1.3.4 which has issues with webpack on the server-side (Ref: ladjs#615). node-form-data@0.2.0 uses another library, mime-types@2.0.3, which does not have these issues.
wali-s
force-pushed
the
update-form-data-dependency
branch
from
00cd4b5
to
10ae2c8
Compare
|
Fixed the version issue. If you mean my webpack bundle, in my particular case, the bundle size is unchanged. I believe because both Details on a related issue that may be fixed by this PR (browserify support): form-data/form-data#95 |
defunctzombie
added a commit
that referenced
this pull request
Apr 5, 2015
Updates node-form-data dependency, 0.1.3->0.2.0, to fix webpack issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SuperAgent depends on node-form-data@0.1.3, which uses node-mime@1.3.4 which has issues with webpack on the server-side (Ref: #615).
node-form-data@0.2.0 uses another library, mime-types@2.0.3, which does not have these issues.