Merge pull request #539 from ozzywalsh/fix-agent-defaults

Call this._setDefaults to set agent defaults
ladjs · Mar 9, 2019 · abf6bc3 · abf6bc3
2 parents 5914936 + 3b13e91
commit abf6bc3
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 3 deletions.
diff --git a/lib/agent.js b/lib/agent.js
@@ -58,6 +58,7 @@ methods.forEach(function(method) {
     req.on('redirect', this._saveCookies.bind(this));
     req.on('redirect', this._attachCookies.bind(this, req));
     this._attachCookies(req);
+    this._setDefaults(req);
 
     return req;
   };

diff --git a/test/supertest.js b/test/supertest.js
@@ -832,7 +832,8 @@ describe('request(app)', function () {
 
 describe('request.agent(app)', function () {
   const app = express();
-  const agent = request.agent(app);
+  const agent = request.agent(app)
+    .set('header', 'hey');
 
   app.use(cookieParser());
 
@@ -841,11 +842,16 @@ describe('request.agent(app)', function () {
     res.send();
   });
 
-  app.get('/return', function (req, res) {
+  app.get('/return_cookies', function (req, res) {
     if (req.cookies.cookie) res.send(req.cookies.cookie);
     else res.send(':(');
   });
 
+  app.get('/return_headers', function (req, res) {
+    if (req.get('header')) res.send(req.get('header'));
+    else res.send(':(');
+  });
+
   it('should save cookies', function (done) {
     agent
       .get('/')
@@ -854,7 +860,13 @@ describe('request.agent(app)', function () {
 
   it('should send cookies', function (done) {
     agent
-      .get('/return')
+      .get('/return_cookies')
+      .expect('hey', done);
+  });
+
+  it('should send global agent headers', function (done) {
+    agent
+      .get('/return_headers')
       .expect('hey', done);
   });
 });