Clarify that .end(..) closes the server
#369
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm doing a cleanup of my repositories, anybody here to accept this change? it's just Readme... |
easternbloc
reviewed
Jan 19, 2017
Readme.md
Outdated
| @@ -210,6 +214,8 @@ describe('request.agent(app)', function(){ | |||
| ### .end(fn) | |||
|
|
|||
| Perform the request and invoke `fn(err, res)`. | |||
| If the call was created with an instance of a server - it **closes** the server, wether it was bound to a port or not. | |||
| Also mind that the `this` context inside teh callback is set to the `supertest.Test` instance, and not the mocha test or any other context you're running in. | |||
There was a problem hiding this comment.
There's a typo, inside teh callback should be inside the callback
There was a problem hiding this comment.
well... till the next cleanup ... I guess... 😛
There was a problem hiding this comment.
¯_(ツ)_/¯ it happens. Thanks for fixing it!
|
@osher Can you please resolve conflicts ? 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.