Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix end() not called when app is started manually #651

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nunofgs
Copy link

@nunofgs nunofgs commented May 15, 2020

Supertest supports passing previously-started apps, ie:

const app = express();
const server = app.listen();

...

await request(server)
  .get('/user')
  .expect(200);

However, when used this way, the server was never called with end().

Note: tests are not passing but not due to this change (already failing in master).

Fixes #634

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jest --detectleaks shows memory leak while using SuperTest with Express
1 participant