Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] enable http2 support #691

Closed
wants to merge 1 commit into from

Conversation

gabrielcsapo
Copy link

Motivation

A lot of the footwork has been done in #494. This continues that work.

@coveralls
Copy link

coveralls commented Dec 7, 2020

Pull Request Test Coverage Report for Build 472

  • 13 of 14 (92.86%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 96.596%

Changes Missing Coverage Covered Lines Changed/Added Lines %
index.js 11 12 91.67%
Totals Coverage Status
Change from base Build 467: -0.7%
Covered Lines: 144
Relevant Lines: 149

💛 - Coveralls

@@ -33,6 +33,7 @@
},
"dependencies": {
"methods": "1.1.2",
"spdy": "^4.0.2",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this go in dev dependencies instead?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do without spdy since Node.js support http2 natively now.
I have taken the liberty to create PR #793 which builds on this.

@lamweili lamweili mentioned this pull request Oct 3, 2022
@titanism
Copy link
Collaborator

titanism commented Oct 4, 2022

Closed via #793 and released in v6.3.0

@titanism titanism closed this Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants