New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix end function when piping on request #742

Open

lafeuil wants to merge 1 commit into ladjs:master from lafeuil:master

lafeuil commented Oct 19, 2021

When I want to pipe to the request :

    const body = Readable.from(JSON.stringify({ name: 'john' }));
    const req = request(app)
      .post('/')
      .set('Content-Type', 'application/json')
      .on('response', function (res) {
        should.exist(res);
        res.status.should.be.equal(200);
        res.text.should.be.equal('john');
        done();
      });
    body.pipe(req);

I have an error Uncaught TypeError: Cannot read property 'call' of undefined

This pull request have :

a unit test to reproduce the issue
the small fix that removes the call to callback function in the end function if it is empty.


          fix end function when piping on request

91ba365

Collaborator

niftylettuce commented Jan 17, 2022

Have you tried again with latest version?

aaharu mentioned this pull request

fix end function when piping on request #832

Open

6 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment