Upgrade to php 8.3 and remove php 8.0 as a dependency. #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Johansson <datasage@gmail.com>
|
merge and release |
samsonasik
reviewed
Apr 18, 2024
samsonasik
reviewed
Apr 18, 2024
samsonasik
reviewed
Apr 18, 2024
samsonasik
requested changes
Apr 18, 2024
Signed-off-by: Dan Johansson <datasage@gmail.com>
|
@samsonasik Removed most of the type hints for now. Understand the concern about compatibility. |
samsonasik
reviewed
Apr 26, 2024
Signed-off-by: Dan Johansson <datasage@gmail.com>
Signed-off-by: Dan Johansson <datasage@gmail.com>
|
@samsonasik All requested changes were made, please review. |
|
Hello @datasage, do you plan to update this PR? Do you need any help? |
Signed-off-by: Dan Johansson <datasage@gmail.com>
|
All CI checks are passing now |
samsonasik
reviewed
May 13, 2024
Signed-off-by: Dan Johansson <datasage@gmail.com>
|
composer.lock need to be regenerated |
Signed-off-by: Dan Johansson <datasage@gmail.com>
samsonasik
approved these changes
May 14, 2024
kersysgediminas
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add PHP 8.3 as a supported version and removed php 8.0 as a supported version.
Included is an update to phpunit 10.x and psalm 5.x.
All the required packages were updated to the minimum version that matched the php version requirments