Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow PHP 8.2, drop PHP 7 #4

Merged
merged 1 commit into from Dec 22, 2022
Merged

Allow PHP 8.2, drop PHP 7 #4

merged 1 commit into from Dec 22, 2022

Conversation

fezfez
Copy link
Contributor

@fezfez fezfez commented Nov 18, 2022

No description provided.

fezfez
fezfez commented Nov 18, 2022
View reviewed changes
src/StorageFactory.php Outdated Show resolved Hide resolved
@fezfez fezfez force-pushed the php8.2 branch 3 times, most recently from 3ca03fe to bdbd118 Compare December 21, 2022 13:25
@fezfez fezfez changed the title Allow PHP 8.2 Allow PHP 8.2, drop PHP 7 Dec 21, 2022
@fezfez
Copy link
Contributor Author

fezfez commented Dec 21, 2022

@Ocramius can you check this plz ⭐ ?

boesing
boesing requested changes Dec 21, 2022
View reviewed changes
Copy link
Member

@boesing boesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

composer.json Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
@fezfez fezfez force-pushed the php8.2 branch 2 times, most recently from 8aa716e to 2873305 Compare December 22, 2022 07:48
@Ocramius
Copy link
Member

Hmm, why is it suddenly trying to install php8.0-random? 🤔

@fezfez
Copy link
Contributor Author

fezfez commented Dec 22, 2022 •
edited

Hmm, why is it suddenly trying to install php8.0-random? thinking

psalm tell me do it 👍

./vendor/bin/psalm
Target PHP version: 8.0 (inferred from composer.json) Extensions enabled:  (unsupported extensions: )
Scanning files...
Deprecation: Psalm stubs for ext-apcu loaded using legacy way. Instead, please declare ext-apcu as dependency in composer.json or use <enableExtensions> directive in Psalm config.
Deprecation: Psalm stubs for ext-random loaded using legacy way. Instead, please declare ext-random as dependency in composer.json or use <enableExtensions> directive in Psalm config.
Analyzing files...

░░
------------------------------
                              
       No errors found!

@fezfez
Copy link
Contributor Author

fezfez commented Dec 22, 2022

i have dropped ext-random from composer.json so ci won't try to install it in php 8.0 and 8.2

@fezfez
Copy link
Contributor Author

fezfez commented Dec 22, 2022

linked to vimeo/psalm#8958

Ocramius
Ocramius reviewed Dec 22, 2022
View reviewed changes
composer.json Outdated Show resolved Hide resolved
@fezfez
Allow PHP 8.2
1c9a61c 
Signed-off-by: Stéphane Demonchaux <demonchaux.stephane@gmail.com>
Ocramius
Ocramius approved these changes Dec 22, 2022
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fezfez!

@Ocramius Ocramius assigned Ocramius and unassigned fezfez Dec 22, 2022
@Ocramius Ocramius merged commit f35b7b1 into laminas:1.0.x Dec 22, 2022
@boesing boesing added this to the 1.1.0 milestone Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MidnightDesign MidnightDesign MidnightDesign left review comments

@boesing boesing boesing requested changes

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
Enhancement
Projects
No open projects
PHP 8.2
Status: Done
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fezfez @Ocramius @MidnightDesign @boesing