Support for laminas/laminas-servicemanager v4
#296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also introduces support for `laminas/laminas-serializer` v3. Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
gsteel
approved these changes
Mar 4, 2024
Comment on lines
+29
to
+33
| 'clear_expired_by_factor' => Plugin\ClearExpiredByFactor::class, | ||
| 'clearexpiredbyfactor' => Plugin\ClearExpiredByFactor::class, | ||
| 'clearExpiredByFactor' => Plugin\ClearExpiredByFactor::class, | ||
| 'ClearExpiredByFactor' => Plugin\ClearExpiredByFactor::class, | ||
| 'exception_handler' => Plugin\ExceptionHandler::class, |
There was a problem hiding this comment.
Is there any value in keeping all of these aliases alive? Would it not be a good time to get rid of them and force users to reference the required implementation by FQCN?
There was a problem hiding this comment.
I was also thinkin of this but besides the fact that it would provide a benefit to projects with psalm, I think its okayish to keep them. Might be something to consider in next major but I would do that with a better way to configure adapters in total, not just enforcing FQCN here.
samsonasik
reviewed
Apr 2, 2024
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This also introduces support for
laminas/laminas-serializerv3 and conflicts withlaminas-serializer<3.0.PluginOptions#getSerializerdoes not create a serializer anymore if astringwas passed beforehand (added to Documentation for v4.0.0 including migration guide #274)