Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance type strictness and add final to a bunch of classes #310

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

boesing
Copy link
Member

@boesing boesing commented Jun 14, 2024

Q A
BC Break yes
QA yes

Description

This adds a bunch of final statements to classes which were not expect to be inherited.

Verified

This commit was signed with the committer’s verified signature.
boesing Maximilian Bösing
This adds a bunch of `final` statements to classes which were not expect to be inherited.

Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
Copy link
Member

@gsteel gsteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@boesing boesing merged commit 53a6e0e into laminas:4.0.x Jun 14, 2024
17 of 18 checks passed
@boesing boesing added this to the 4.0.0 milestone Jun 14, 2024
@boesing boesing deleted the qa/enhance-type-strictness branch June 14, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants