Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine duplicated tool configuration for Docs linting #165

Closed
wants to merge 1 commit into from

Conversation

gsteel
Copy link
Member

@gsteel gsteel commented Dec 19, 2022

laminas-filter matrix is failing to detect any "tools" here:
https://github.com/laminas/laminas-filter/actions/runs/3731691570/jobs/6330902330#step:3:99

As part of this, I noticed that the Doc Lint tool config was duplicated in tools.ts

@gsteel gsteel added this to the 1.22.0 milestone Dec 19, 2022
@gsteel
Copy link
Member Author

gsteel commented Dec 19, 2022

Needs #164 and a rebase

@internalsystemerror
Copy link
Member

Actually those two jobs have different files to check ... doc/... vs docs/.... You will need to update the filesToCheck array to include both

Signed-off-by: George Steel <george@net-glue.co.uk>
@gsteel gsteel changed the title Remove duplicated tool configuration for Docs linting Combine duplicated tool configuration for Docs linting Dec 19, 2022
@gsteel
Copy link
Member Author

gsteel commented Dec 19, 2022

Thanks @internalsystemerror - saved me from a proper face palm there!

@internalsystemerror
Copy link
Member

Ohhhhhh, and the command changes depending on the files to check :/ docs vs doc ... So that's probably why they were in twice.

@gsteel
Copy link
Member Author

gsteel commented Dec 19, 2022

Let's just close this one unmerged!!!

@gsteel gsteel closed this Dec 19, 2022
@gsteel gsteel deleted the duplicate-tool branch December 19, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants