[Php74] Apply PHP 7.4 syntax and typed properties (for private modifier) #108
+23
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
samsonasik
force-pushed
the
php74-syntax
branch
from
ff7e8da to
d5c06a8
Compare
Ocramius
approved these changes
Sep 26, 2021
src/Generator/ClassGenerator.php
Outdated
| // This loop is just validating that the given `$implementedInterfaces` contains valid syntax/symbols | ||
| return TypeGenerator::fromTypeString($implementedInterface); | ||
| }, $implementedInterfaces); | ||
| // This loop is just validating that the given `$implementedInterfaces` contains valid syntax/symbols |
There was a problem hiding this comment.
I wonder if we can just drop this?
samsonasik
commented
Sep 26, 2021
…d syntax/symbols Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
|
All green 🎉 |
Ocramius
approved these changes
Sep 26, 2021
|
Thanks @samsonasik! |
michaelpetri
pushed a commit
to michaelpetri/laminas-code
that referenced
this pull request
Nov 15, 2021
[Php74] Apply PHP 7.4 syntax and typed properties (for private modifiers) Signed-off-by: Michael Petri <mpetri@lyska.io>
michaelpetri
pushed a commit
to michaelpetri/laminas-code
that referenced
this pull request
Nov 15, 2021
[Php74] Apply PHP 7.4 syntax and typed properties (for private modifiers) Signed-off-by: Michael Petri <mpetri@lyska.io>
michaelpetri
pushed a commit
to michaelpetri/laminas-code
that referenced
this pull request
Nov 24, 2021
[Php74] Apply PHP 7.4 syntax and typed properties (for private modifiers) Signed-off-by: Michael Petri <mpetri@lyska.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Php74] Apply PHP 7.4 syntax and typed properties (for private modifier) to keep BC.