Add initial use cases for Enum generation #109
Conversation
There was a problem hiding this comment.
The bulk of the static analysis errors are due to the engine needing to infer types, and not being able to do so. The way to correct that is to verify them before doing an operation. For values in arrays, check that the array key exists, and then that the value conforms to what is required, before performing an operation. In other cases, just make sure that the typehints provided are correct, particularly in annotations. If needed, uses webmozart/assert to do the validations.
|
Thanks @weierophinney for the initial review. I'll keep your feedback in account as I work further in the PR |
There was a problem hiding this comment.
Few minor suggestions, mainly for readability. After making them, I think you can go ahead and remove the draft status, and @Ocramius can do final review.
|
@weierophinney Thank you for the suggestions. I marked the PR as ready for review. |
Supports generating Enums that are pure or have backed values. Signed-off-by: Agustin Gomes <me@agustingomes.com>
There was a problem hiding this comment.
Overall excellent:
- the fact that implementations are
@internalgives us space to improve later - everything else is simple and to the point
I'll proceed to merge, and will factor in the last comments by @michaelpetri ( #109 (review) )
Ref: #109 (review) In this change: * we remove the `polyfill/test` directory: we will use `<<<'PHP'` blocks directly in the test sources, in order to generate the classes that we need to verify enumerable type code generation * we replace `PHP_VERSION_ID`-based checks with PHPUnit's built-in `@requires PHP > 8.1` and similar * fixed some docblocks in tests * re-generated psalm baseline to reflect the fact that multiple issues were solved
|
🚢 Thanks @agustingomes @michaelpetri @weierophinney! Gonna cut a release after dependency upgrades |
Description
This PR Enables the creation of Enum objects for the following use cases:
Fixes #100