Added support for readonly properties

[michaelpetri]

Q	A
Documentation	no
Bugfix	no
BC Break	no
New Feature	yes
RFC	no
QA	no

Description

Requested with #101
Fixes #101

[Ocramius]

We should probably get rid of this public API - let's consider #generate() our main API, while reading state is probably not relevant (and not the use-case for this class)

[michaelpetri]

We use it in tests, also this version provides such an interface for all other modifiers, imo we should keep it. Also keep in mind this is just a bool, so not much which can be misused?! But your decision!

[Ocramius]

Remember that any API we add is API we have to maintain long-term too.

No big issue here though, let's add it 👍

[Ocramius]

Static analysis failing due to parsing: I think I need to set up dependabot here 🤔

[michaelpetri]

Static analysis failing due to parsing: I think I need to set up dependabot here thinking

I assume the problem here is that psalm runs on php80 and can not parse the test assets which contain php81 syntax?
Maybe the files just need to be excluded. Will check later when we have our half day for research.

[michaelpetri]

Static analysis failing due to parsing: I think I need to set up dependabot here thinking

I assume the problem here is that psalm runs on php80 and can not parse the test assets which contain php81 syntax? Maybe the files just need to be excluded. Will check later when we have our half day for research.

The problem is indeed he PHP version <8.1.0, unfortunately excluding the file via psalm.xml is not working. As discussed in slack i dropped the Class from code base and replaced it by an eval() to generate it at runtime.

[Ocramius]

LGTM 🚢

[Ocramius]

HMM, static analysis still failed 🤔

Run vendor/bin/psalm  --output-format=github --shepherd --stats
Scanning files...
Analyzing files...

░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░  60 / 185 (32%)
░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░ 120 / 185 (64%)
░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░ 180 / 185 (97%)
░░░░░
Error: Syntax error, unexpected T_STRING, expecting T_VARIABLE on line 9 (see https://psalm.dev/173)
🐑 results sent to shepherd.dev 🐑
Error: Process completed with exit code 2.

[michaelpetri]

HMM, static analysis still failed 🤔

Run vendor/bin/psalm  --output-format=github --shepherd --stats
Scanning files...
Analyzing files...

░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░  60 / 185 (32%)
░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░ 120 / 185 (64%)
░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░ 180 / 185 (97%)
░░░░░
Error: Syntax error, unexpected T_STRING, expecting T_VARIABLE on line 9 (see https://psalm.dev/173)
🐑 results sent to shepherd.dev 🐑
Error: Process completed with exit code 2.

Okay that's strange, will try to reproduce local.

[michaelpetri]

Seems like i removed my own commit after the soft reset / rebase issues i faced the last time 🤷‍♂️

Anyway, removed class again, added eval to generate it while runtime. Unfortunately i was not able to solve this issue:

ERROR: MixedAssignment - test/Generator/PropertyGeneratorTest.php:399:9 - Unable to determine the type that $generator is being assigned to (see https://psalm.dev/032)
        $generator = PropertyGenerator::fromReflection($reflectionProperty);

So i decided to add it to baseline, any ideas?

I also realized that psalm is only running on PHP 8.0 in CI, should we extend matrix here as well?

[Ocramius]

LGTM 🚢

Thanks @michaelpetri!