Skip to content

Added support for final const properties #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

michaelpetri
Copy link

Q A
Documentation no
Bugfix no
BC Break no
New Feature yes
RFC no
QA no

Description

Fixes #103

Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a ::fromReflection(...) test scenario for this one, before considering it done.

Other than that, nice and clean!

@michaelpetri michaelpetri force-pushed the feature/add-final-const-support branch from 23f0833 to e0b94b6 Compare November 15, 2021 22:01
@michaelpetri
Copy link
Author

We need a ::fromReflection(...) test scenario for this one, before considering it done.

Other than that, nice and clean!

Unfortunately we can not add a test to PropertyGenerator::fromReflection() since the signature only allows to pass a PropertyReflection and no ReflectionClassConstant. But i added tests for ClassGenerator::fromReflection() and ClassGenerator::fromArray().

In addition i refined the return types from self to static.

Signed-off-by: Michael Petri <mpetri@lyska.io>
@michaelpetri michaelpetri force-pushed the feature/add-final-const-support branch from e0b94b6 to 75b3bc4 Compare November 20, 2021 13:58
@Ocramius Ocramius self-assigned this Nov 20, 2021
@Ocramius Ocramius added this to the 4.5.0 milestone Nov 20, 2021
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 excellent work, thanks @michaelpetri!

@Ocramius Ocramius merged commit a98efae into laminas:4.5.x Nov 20, 2021
@michaelpetri michaelpetri deleted the feature/add-final-const-support branch November 20, 2021 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP 8.1 final constant support
2 participants