Skip to content

Drop laminas/laminas-zendframework-bridge from suggested dependencies #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2021

Conversation

PowerKiKi
Copy link
Contributor

Q A
Documentation no
Bugfix yes
BC Break no
New Feature no
RFC no
QA no

Description

Increase performance by removing a compatibility layer while not introducing breaking changes.

This follow the process described in details in:

https://github.com/laminas/technical-steering-committee/blob/main/meetings/minutes/2021-08-02-TSC-Minutes.md#remove-laminaslaminas-zendframework-bridge-dependency-from-our-packages

@Koen1999
Copy link

Koen1999 commented Dec 5, 2021

Perhaps remove the suggestion from here as well:
https://github.com/laminas/laminas-code/blob/4.5.x/composer.json#L29

@PowerKiKi
Copy link
Contributor Author

Done in squashed commit

Verified

This commit was signed with the committer’s verified signature.
mayeut Matthieu Darbois
…patibility

Increase performance by removing a compatibility layer while **not** introducing breaking changes.

This follow the process described in details in:

https://github.com/laminas/technical-steering-committee/blob/main/meetings/minutes/2021-08-02-TSC-Minutes.md#remove-laminaslaminas-zendframework-bridge-dependency-from-our-packages
Signed-off-by: Adrien Crivelli <adrien.crivelli@gmail.com>
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - will edit title

@Ocramius Ocramius changed the title Drop laminas/laminas-zendframework-bridge and zendframework/* compatibility Drop laminas/laminas-zendframework-bridge from suggested dependencies Dec 6, 2021
@Ocramius Ocramius added this to the 4.5.0 milestone Dec 6, 2021
@Ocramius Ocramius self-assigned this Dec 6, 2021
@Ocramius Ocramius merged commit 7fcc8ea into laminas:4.5.x Dec 6, 2021
@Ocramius
Copy link
Member

Ocramius commented Dec 6, 2021

Thanks @PowerKiKi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants