Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReflectionEnum is no longer final in newer PHP 8.1.x releases #132

Merged
merged 1 commit into from
Jun 6, 2022
Merged

ReflectionEnum is no longer final in newer PHP 8.1.x releases #132

merged 1 commit into from
Jun 6, 2022
+1 −1

Conversation

bendavies
Copy link
Contributor

@bendavies bendavies commented Jun 6, 2022 •
edited
Loading

Q A
Documentation no
Bugfix yes
BC Break no
New Feature no
RFC no
QA no

Description

ReflectionEnum is not final.
this somehow causes errror when psalm and phpstan are installed together, and results in:

PHP Fatal error:  Class PHPStan\BetterReflection\Reflection\Adapter\ReflectionEnum may not inherit from final class (ReflectionEnum) in phar:///.../vendor/phpstan/phpstan/phpstan.phar/vendor/ondrejmirtes/better-reflection/src/Reflection/Adapter/ReflectionEnum.php on line 30

@bendavies bendavies force-pushed the ReflectionEnum-is-not-final branch from 0285079 to b84aa6c Compare June 6, 2022 11:19
@bendavies bendavies changed the base branch from 4.6.x to 4.5.x June 6, 2022 11:19
@bendavies bendavies force-pushed the ReflectionEnum-is-not-final branch from b84aa6c to 8e5f5ee Compare June 6, 2022 11:20
@bendavies bendavies marked this pull request as ready for review June 6, 2022 11:23
Ocramius
Ocramius approved these changes Jun 6, 2022
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bendavies!

@Ocramius Ocramius self-assigned this Jun 6, 2022
@bendavies
ReflectionEnum is not final

Verified

This commit was signed with the committer’s verified signature. The key has expired.
mtorromeo Massimiliano Torromeo
GPG key ID: 11675C743429DDEF
Expired
Verified
Learn about vigilant mode
ec99414 
Signed-off-by: Ben Davies <ben.davies@gmail.com>
@bendavies bendavies force-pushed the ReflectionEnum-is-not-final branch from 8e5f5ee to ec99414 Compare June 6, 2022 11:24
@Ocramius Ocramius modified the milestones: 4.6.0, 4.5.2 Jun 6, 2022
@Ocramius Ocramius merged commit da01fb7 into laminas:4.5.x Jun 6, 2022
@bendavies
Copy link
Contributor Author

thankyou!

@Ocramius Ocramius changed the title ReflectionEnum is not final ReflectionEnum is no longer final in newer PHP 8.1.x releases Jun 6, 2022
@github-actions github-actions bot mentioned this pull request Jun 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius

Assignees

@Ocramius Ocramius

Labels
Enhancement
Projects
None yet
Milestone
4.5.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bendavies @Ocramius