fix: complete ReflectionEnum polyfill #150
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanpoulain
force-pushed
the
patch-1
branch
2 times, most recently
from
24c0177
to
efa495b
Compare
Since the polyfill is autoloaded, PHPStan seems to discover the class, even with the early return: Call to an undefined method ReflectionEnum::getCases() Completing this polyfill solves the issue. Signed-off-by: Alan Poulain <contact@alanpoulain.eu>
Ocramius
reviewed
Nov 18, 2022
| @@ -5,10 +5,27 @@ | |||
| } | |||
|
|
|||
| /** @internal */ | |||
| class ReflectionEnum | |||
| class ReflectionEnum extends \ReflectionClass | |||
There was a problem hiding this comment.
I decided to drop PHP 8.0 support anyway, which will remove the polyfill entirely.
That said, patch stays open until I'm done with my changes.
|
Handled in #154 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since the polyfill is autoloaded, PHPStan seems to discover the class, even with the early return:
Completing this polyfill solves the issue.